Skip to content

Fix contacts backup job interval#6139

Merged
tobiasKaminsky merged 1 commit into
masterfrom
ezaquarii/fix-contacts-backup-period
May 25, 2020
Merged

Fix contacts backup job interval#6139
tobiasKaminsky merged 1 commit into
masterfrom
ezaquarii/fix-contacts-backup-period

Conversation

@ezaquarii

@ezaquarii ezaquarii commented May 24, 2020

Copy link
Copy Markdown
Collaborator

Job interval was set in ms, when API requred minutes.
Use of invalid time unit resulted in period of ~164 years.

This change removes ms interval constants and sets
proper contact backup job period.

Fixes #6041

Signed-off-by: Chris Narkiewicz hello@ezaquarii.com

@ezaquarii
Fix contacts backup job interval
be2a448 
Job interval was set in ms, when API requred minutes.
Use of invalid time unit resulted in period of ~164 years.

This change removes ms interval constants and sets
proper contact backup job period.

Fixes #6041

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
@ezaquarii

ezaquarii commented May 24, 2020

Copy link
Copy Markdown
Collaborator Author

/backport to stable-3.12

@nextcloud-android-bot

nextcloud-android-bot commented May 24, 2020

Copy link
Copy Markdown
Collaborator

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14130.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nextcloud-android-bot

nextcloud-android-bot commented May 24, 2020

Copy link
Copy Markdown
Collaborator

Codacy

389

Lint

TypemasterPR
Warnings9595
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings27
Correctness Warnings64
Internationalization Warnings9
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings74
Security Warnings44
Dodgy code Warnings139
Total370

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings27
Correctness Warnings64
Internationalization Warnings9
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings74
Security Warnings44
Dodgy code Warnings139
Total370

@ezaquarii

ezaquarii commented May 24, 2020

Copy link
Copy Markdown
Collaborator Author 
com.********.client.EndToEndRandomIT > createSubFolders[android-27(AVD) - 8.1.0] �[31mFAILED �[0m
	java.lang.RuntimeException: Could not clean up after failing folder creation!
	at com.owncloud.android.operations.CreateFolderOperation.encryptedCreate(CreateFolderOperation.java:232)

com.********.client.EndToEndRandomIT > createSubFoldersWithFiles[android-27(AVD) - 8.1.0] �[31mFAILED �[0m
	java.lang.RuntimeException: Could not clean up after failing folder creation!
	at com.owncloud.android.operations.CreateFolderOperation.encryptedCreate(CreateFolderOperation.java:232)

com.********.client.EndToEndRandomIT > uploadOneFile[android-27(AVD) - 8.1.0] �[31mFAILED �[0m
	java.lang.AssertionError: Unexpected exception
	at org.junit.Assert.fail(Assert.java:88)

com.********.client.EndToEndRandomIT > run[android-27(AVD) - 8.1.0] �[31mFAILED �[0m
	java.lang.RuntimeException: Could not clean up after failing folder creation!
	at com.owncloud.android.operations.CreateFolderOperation.encryptedCreate(CreateFolderOperation.java:232)

com.********.client.EndToEndRandomIT > createFolder[android-27(AVD) - 8.1.0] �[31mFAILED �[0m
	java.lang.RuntimeException: Could not clean up after failing folder creation!
	at com.owncloud.android.operations.CreateFolderOperation.encryptedCreate(CreateFolderOperation.java:232)

com.********.client.EndToEndRandomIT > deleteFile[android-27(AVD) - 8.1.0] �[31mFAILED �[0m
	java.lang.AssertionError: Unexpected exception
	at org.junit.Assert.fail(Assert.java:88)

com.********.client.EndToEndRandomIT > pseudoRandom[android-27(AVD) - 8.1.0] �[31mFAILED �[0m
	java.lang.AssertionError: Unexpected exception
	at org.junit.Assert.fail(Assert.java:88)

com.owncloud.android.ScreenshotsIT > gridViewScreenshot[android-27(AVD) - 8.1.0] �[31mFAILED �[0m
	androidx.test.espresso.NoMatchingViewException: No views in hierarchy found matching: ((is displayed on the screen to the user and with content description text: is "More options") or (is displayed on the screen to the user and with class name: a string ending with "OverflowMenuButton"))
	

com.owncloud.android.files.services.FileUploaderIT > testKeepServer[android-27(AVD) - 8.1.0] �[31mFAILED �[0m
	java.lang.AssertionError: Socket exception
	at org.junit.Assert.fail(Assert.java:88)

Flaky e2e test. IMO not related.

@tobiasKaminsky
tobiasKaminsky merged commit 6d4597b into master May 25, 2020
@delete-merged-branch
delete-merged-branch Bot deleted the ezaquarii/fix-contacts-backup-period branch May 25, 2020 09:30
@backportbot-nextcloud backportbot-nextcloud Bot mentioned this pull request May 25, 2020
Merged
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.13.0 milestone May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes
@tobiasKaminsky tobiasKaminsky tobiasKaminsky approved these changes

Assignees

No one assigned

Labels

3. to review

Projects

None yet

Milestone

Nextcloud App 3.13.0

Development

Successfully merging this pull request may close these issues.

Daily contacts backup didn't work at 3.12.0 rc1

4 participants

@ezaquarii @nextcloud-android-bot @AndyScherzinger @tobiasKaminsky